QPQ-AG/gmbytecode
10
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 9 Wiki Activity

Add accepted types to operator declarations. Check opcode numbering. #160

Merged
zxq9 merged 4 commits from PT-164597753-add-types-to-op-defs into master 2019-05-24 20:21:50 +09:00
Conversation 4 Commits 4 Files Changed 3 +153 -135
zxq9 commented 2019-05-24 15:52:41 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: happi

Added types for arguments and results of opcodes.
For now for documentation purposes.

We could add a type check pass to check that the code is type correct. This could be a utility function one could use to check the bytecode before doing a create call transaction.
Thoughts?

I would also appreciate comments on the "type language". For now there are no type variables and all lists, tuples and maps are of the same type.

*Created by: happi* Added types for arguments and results of opcodes. For now for documentation purposes. We could add a type check pass to check that the code is type correct. This could be a utility function one could use to check the bytecode before doing a create call transaction. Thoughts? I would also appreciate comments on the "type language". For now there are no type variables and all lists, tuples and maps are of the same type.
gorillainduction (Migrated from gitlab.com) approved these changes 2019-05-24 15:52:41 +09:00
zxq9 commented 2019-05-24 17:49:54 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved
gorillainduction commented 2019-05-24 20:02:15 +09:00 (Migrated from gitlab.com)
Copy Link

approved this merge request

approved this merge request
zxq9 commented 2019-05-24 20:21:50 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: happi at 2019-05-24 11:21:50 UTC

*Merged by: happi at 2019-05-24 11:21:50 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
gorillainduction
Labels
Clear labels
WIP
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/gmbytecode#160
No description provided.
Delete Branch "PT-164597753-add-types-to-op-defs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?