QPQ-AG/gmbytecode
10
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 9 Wiki Activity

Correct arity for BLOCKHASH #150

Merged
gorillainduction merged 2 commits from PT-165760129-FATE-blockhash into master 2019-05-02 19:28:58 +09:00
Conversation 7 Commits 2 Files Changed 2 +2 -3
gorillainduction commented 2019-05-02 17:47:31 +09:00 (Migrated from gitlab.com)
Copy Link

https://www.pivotaltracker.com/story/show/165760129

https://www.pivotaltracker.com/story/show/165760129
zxq9 commented 2019-05-02 17:54:48 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved
zxq9 commented 2019-05-02 18:17:27 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: lucafavatella

I see that current block hash can be achieved by using this with GENERATION (for current height). Ok.

*Created by: lucafavatella* I see that current block hash can be achieved by using this with GENERATION (for current height). Ok.
zxq9 commented 2019-05-02 18:19:20 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: lucafavatella

Hash of key block starting generation? Hash of previous key block? Hash of previous block i.e. key or micro?

*Created by: lucafavatella* Hash of key block starting generation? Hash of previous key block? Hash of previous block i.e. key or micro?
zxq9 commented 2019-05-02 18:21:32 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: lucafavatella

Any? Or one of the most recent 256 ones?

Can height be below genesis i.e. negative? If so, what is behaviour?

Any special behavioury in state channels - on- (force progress) or off-chain?

Ref f1a1ca14a7/contracts/aevm.md (L81-L87)

*Created by: lucafavatella* Any? Or one of the most recent 256 ones? Can height be below genesis i.e. negative? If so, what is behaviour? Any special behavioury in state channels - on- (force progress) or off-chain? Ref https://github.com/aeternity/protocol/blame/f1a1ca14a7f0c95aaeba765b8bec76c77f358493/contracts/aevm.md#L81-L87
zxq9 commented 2019-05-02 18:56:47 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: ThomasArts

Review: Approved

*Created by: ThomasArts* **Review:** Approved
gorillainduction commented 2019-05-02 19:28:15 +09:00 (Migrated from gitlab.com)
Copy Link

I don't think these strings are supposed to describe the full semantics of the instructions, but if they are, we need a total overhaul at some point.

I'll leave it as it is for now.

I don't think these strings are supposed to describe the full semantics of the instructions, but if they are, we need a total overhaul at some point. I'll leave it as it is for now.
zxq9 commented 2019-05-02 19:28:58 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: gorillainduction at 2019-05-02 10:28:58 UTC

*Merged by: gorillainduction at 2019-05-02 10:28:58 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/gmbytecode#150
No description provided.
Delete Branch "PT-165760129-FATE-blockhash"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?