QPQ-AG/gmbytecode
10
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 9 Wiki Activity

Pt 164601244 add hash and signature type #139

Merged
zxq9 merged 7 commits from PT-164601244-add-hash-and-signature-type into master 2019-03-26 01:57:13 +09:00
Conversation 16 Commits 7 Files Changed 10 +430 -212
zxq9 commented 2019-03-22 17:35:12 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: happi

Also add different types of chain objects (aka addresses).

*Created by: happi* Also add different types of chain objects (aka addresses).
gorillainduction (Migrated from gitlab.com) approved these changes 2019-03-22 17:35:12 +09:00
zxq9 commented 2019-03-22 17:39:25 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Dismissed

LGTM

*Created by: hanssv* **Review:** Dismissed LGTM
zxq9 commented 2019-03-22 18:57:18 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: happi

@hanssv Note that I did not add any ops on these types yet. We should probably at least have hash_to_string and signature_to_string. The hash ops should be string->hash. (and possibly 'A->hash). We can add the ops later when we know exactly what we want.

*Created by: happi* @hanssv Note that I did not add any ops on these types yet. We should probably at least have hash_to_string and signature_to_string. The hash ops should be string->hash. (and possibly 'A->hash). We can add the ops later when we know exactly what we want.
gorillainduction commented 2019-03-25 18:24:44 +09:00 (Migrated from gitlab.com)
Copy Link

addresse -> address

`addresse -> address`
gorillainduction commented 2019-03-25 18:25:14 +09:00 (Migrated from gitlab.com)
Copy Link

addresse -> address

`addresse -> address`
gorillainduction commented 2019-03-25 18:25:28 +09:00 (Migrated from gitlab.com)
Copy Link

addresse -> address

`addresse -> address`
gorillainduction commented 2019-03-25 18:28:23 +09:00 (Migrated from gitlab.com)
Copy Link

addresse -> address

`addresse -> address`
gorillainduction commented 2019-03-25 18:28:26 +09:00 (Migrated from gitlab.com)
Copy Link

addresse -> address

`addresse -> address`
gorillainduction commented 2019-03-25 18:28:32 +09:00 (Migrated from gitlab.com)
Copy Link

addresse -> address

`addresse -> address`
gorillainduction commented 2019-03-25 18:35:36 +09:00 (Migrated from gitlab.com)
Copy Link

Review: Commented

I don't know if this is relevant, but I note that this code is using plain base64 and base58 rather than the checked version that is used in the API. This might be very confusing in the end.

**Review:** Commented I don't know if this is relevant, but I note that this code is using plain base64 and base58 rather than the checked version that is used in the API. This might be very confusing in the end.
zxq9 commented 2019-03-25 19:22:57 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: happi

I don't know if this is relevant, but I note that this code is using plain base64 and base58 rather than the checked version that is used in the API. This might be very confusing in the end.

Good catch. I'll update the code to use aeserialization now that it exists.

*Created by: happi* > I don't know if this is relevant, but I note that this code is using plain base64 and base58 rather than the checked version that is used in the API. This might be very confusing in the end. Good catch. I'll update the code to use aeserialization now that it exists.
zxq9 commented 2019-03-25 21:50:37 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved
gorillainduction commented 2019-03-25 22:54:12 +09:00 (Migrated from gitlab.com)
Copy Link

Shouldn't you match on the first character as well? Is it really anything?

Shouldn't you match on the first character as well? Is it really anything?
gorillainduction commented 2019-03-25 22:56:00 +09:00 (Migrated from gitlab.com)
Copy Link

approved this merge request

approved this merge request
zxq9 commented 2019-03-26 01:55:52 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: happi

It is either @ or $ but the scanner makes sure of that, matching on that with a when-clause ( C == $$ or c == $@ ) could be done but it would be a bit redundant.

*Created by: happi* It is either @ or $ but the scanner makes sure of that, matching on that with a when-clause ( C == $$ or c == $@ ) could be done but it would be a bit redundant.
zxq9 commented 2019-03-26 01:57:13 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: happi at 2019-03-25 16:57:13 UTC

*Merged by: happi at 2019-03-25 16:57:13 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
gorillainduction
Labels
Clear labels
WIP
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/gmbytecode#139
No description provided.
Delete Branch "PT-164601244-add-hash-and-signature-type"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?