QPQ-AG/gmbytecode
10
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 9 Wiki Activity

Pt 164325512 variant constants #130

Merged
zxq9 merged 9 commits from PT-164325512-variant-constants into fortuna 2019-03-01 21:05:25 +09:00
Conversation 7 Commits 9 Files Changed 5 +231 -47
zxq9 commented 2019-03-01 20:15:47 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: happi

*Created by: happi*
zxq9 commented 2019-03-01 20:19:34 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

%%%       9. Variants: (| Size | Tag | ( Elements ) |)
*Created by: UlfNorell* ```suggestion:-0+0 %%% 9. Variants: (| Size | Tag | ( Elements ) |) ```
zxq9 commented 2019-03-01 20:21:10 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

9. Variants: (| Size | Tag | ( Elements ) |)
*Created by: UlfNorell* ```suggestion:-0+0 9. Variants: (| Size | Tag | ( Elements ) |) ```
zxq9 commented 2019-03-01 20:25:08 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Why do you need the Size here? Isn't it always length(Variants)?

*Created by: UlfNorell* Why do you need the `Size` here? Isn't it always `length(Variants)`?
zxq9 commented 2019-03-01 20:29:52 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: happi

True. Just thought that when checking this type it would be nice to check that Tag < Size first without calculating length. But not strictly needed. (in the decoded format.)

*Created by: happi* True. Just thought that when checking this type it would be nice to check that Tag < Size first without calculating length. But not strictly needed. (in the decoded format.)
zxq9 commented 2019-03-01 20:44:35 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Review: Approved

*Created by: UlfNorell* **Review:** Approved
zxq9 commented 2019-03-01 20:45:50 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved
zxq9 commented 2019-03-01 21:05:25 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: happi at 2019-03-01 12:05:25 UTC

*Merged by: happi at 2019-03-01 12:05:25 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/gmbytecode#130
No description provided.
Delete Branch "PT-164325512-variant-constants"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?