QPQ-AG/gmbytecode
10
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 9 Wiki Activity

Fix bits formatting and parsing. #129

Merged
zxq9 merged 1 commits from fix_bits_formatting into fortuna 2019-03-01 18:36:18 +09:00
Conversation 6 Commits 1 Files Changed 2 +21 -1
zxq9 commented 2019-03-01 06:21:32 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: happi

*Created by: happi*
zxq9 commented 2019-03-01 17:10:39 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved
zxq9 commented 2019-03-01 17:44:41 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Shorter (but tastes may vary):

    Bit = $0 + (N band 1),
    format_bits(N bsr 1, [Bit|Acc]).
*Created by: UlfNorell* Shorter (but tastes may vary): ```erlang Bit = $0 + (N band 1), format_bits(N bsr 1, [Bit|Acc]). ```
zxq9 commented 2019-03-01 17:45:26 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

and then

    Bit = $1 - (N band 1),

here

*Created by: UlfNorell* and then ```erlang Bit = $1 - (N band 1), ``` here
zxq9 commented 2019-03-01 17:46:00 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Review: Approved

*Created by: UlfNorell* **Review:** Approved
zxq9 commented 2019-03-01 18:34:11 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: happi

Thanks, Ill update this in my next PR.

*Created by: happi* Thanks, Ill update this in my next PR.
zxq9 commented 2019-03-01 18:36:18 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: happi at 2019-03-01 09:36:18 UTC

*Merged by: happi at 2019-03-01 09:36:18 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/gmbytecode#129
No description provided.
Delete Branch "fix_bits_formatting"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?