QPQ-AG/GajuMine
11
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Correct type error in gmc_conf:is_key/1 #17

Closed
uwiger wants to merge 0 commits from uw-is_key-type-error into master
pull from: uw-is_key-type-error
merge into: :master
Conversation 3 Commits - Files Changed -
uwiger commented 2025-11-21 04:37:08 +09:00
Owner
Copy Link
Copy Source

The checking of extra account keys will filter out perfectly good keys, as the function gmser_api_encoder:decode/1 expects a binary, but is fed a list.

The checking of extra account keys will filter out perfectly good keys, as the function `gmser_api_encoder:decode/1` expects a binary, but is fed a list.
uwiger added 1 commit 2025-11-21 04:37:12 +09:00
Correct type error in gmc_conf:is_key/1 b1e649961c
uwiger requested review from spivee 2025-11-21 04:37:13 +09:00
uwiger requested review from zxq9 2025-11-21 04:37:14 +09:00
zxq9 commented 2025-11-21 11:55:07 +09:00
Owner
Copy Link
Copy Source

Oh, dhoh!
I just noticed you had this PR submitted right after I pushed one. ugh.
I like MysteryBin more than inlining it how I did it because it's funny.

Oh, dhoh! I just noticed you had this PR submitted right after I pushed one. ugh. I like `MysteryBin` more than inlining it how I did it because it's funny.
zxq9 added 1 commit 2025-11-21 11:56:59 +09:00
Merge branch 'master' into uw-is_key-type-error 3fb82b59a8
zxq9 approved these changes 2025-11-21 12:00:14 +09:00
zxq9 left a comment
Owner
Copy Link
Copy Source

Thanks!

Thanks!
zxq9 commented 2025-11-21 12:00:23 +09:00
Owner
Copy Link
Copy Source

Hm. I merged this offline because of the conflict, but don't know how to make this appear "done" here other than closing it.
Anyway, merged.

Hm. I merged this offline because of the conflict, but don't know how to make this appear "done" here other than closing it. Anyway, merged.
zxq9 closed this pull request 2025-11-21 12:00:23 +09:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
spivee
zxq9
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 pig lipstick
Muggle-facing enhancements
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Dagadunn Pickmick apex132 dimitar.p.ivanov flambard (Markus Flambard) gchewy hans_sv pharpend spivee (Jarvis Carroll) thescientress (Cecille de Jesus) uwiger (Ulf Wiger) zxq9 (Craig Everett)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/GajuMine#17