QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

PT-163053747 Add missing type check of init function #494

Merged
zxq9 merged 1 commits from PT-163053747-missing-init-type-check into master 2019-01-09 00:35:24 +09:00
Conversation 7 Commits 1 Files Changed 4 +40 -2
zxq9 commented 2019-01-08 20:32:08 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

*Created by: UlfNorell* - [PT-163053747](https://www.pivotaltracker.com/story/show/163053747)
gorillainduction (Migrated from gitlab.com) approved these changes 2019-01-08 20:32:08 +09:00
gorillainduction commented 2019-01-08 21:26:17 +09:00 (Migrated from gitlab.com)
Copy Link

approved this merge request

approved this merge request
zxq9 commented 2019-01-08 23:48:35 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: ThomasArts

Review: Approved

*Created by: ThomasArts* **Review:** Approved
zxq9 commented 2019-01-08 23:48:45 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved
zxq9 commented 2019-01-09 00:02:19 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

There needs to be a bump PR in epoch aeternity repo?

*Created by: hanssv* There needs to be a bump PR in ~~`epoch`~~ `aeternity` repo?
zxq9 commented 2019-01-09 00:35:24 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: UlfNorell at 2019-01-08 15:35:24 UTC

*Merged by: UlfNorell at 2019-01-08 15:35:24 UTC*
zxq9 commented 2019-01-09 00:35:55 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

@hanssv make that part of your PR? Since it's related.

*Created by: UlfNorell* @hanssv make that part of your PR? Since it's related.
Sign in to join this conversation.
Reviewers
No Reviewers
gorillainduction
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#494
No description provided.
Delete Branch "PT-163053747-missing-init-type-check"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?