QPQ-AG/sophia
10
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Namespace overlap error is missing filename/location #378

New Issue
Closed
opened 2022-04-28 00:15:13 +09:00 by zxq9 · 7 comments
zxq9 commented 2022-04-28 00:15:13 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: dincho

Compiling of the contract:

@compiler >= 6

include "BLS12_381.aes"

namespace BLS12_381 =
    type fp = int

main contract Bug =
    type number = int

leads to the following error

Type error in 'contracts/Bug.aes' at line 5, col 11:
The namespace BLS12_381 (at line 5, column 11) has the same name as a namespace at line 1, column 11

which reports wrong namespace location obviously

*Created by: dincho* Compiling of the contract: ``` @compiler >= 6 include "BLS12_381.aes" namespace BLS12_381 = type fp = int main contract Bug = type number = int ``` leads to the following error ``` Type error in 'contracts/Bug.aes' at line 5, col 11: The namespace BLS12_381 (at line 5, column 11) has the same name as a namespace at line 1, column 11 ``` which reports wrong namespace location obviously
zxq9 commented 2022-04-28 00:23:43 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: dincho

Perhaps the compiler annotation is not considered ? 🤔

*Created by: dincho* Perhaps the compiler annotation is not considered ? 🤔
zxq9 commented 2022-04-28 00:24:40 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: dincho

Perhaps the compiler annotation is not considered ? 🤔

Nah, same error (location) with:

include "Set.aes"
include "BLS12_381.aes"

namespace BLS12_381 =
    type fp = int

main contract Bug =
    type number = int
*Created by: dincho* > Perhaps the compiler annotation is not considered ? 🤔 Nah, same error (location) with: ``` include "Set.aes" include "BLS12_381.aes" namespace BLS12_381 = type fp = int main contract Bug = type number = int ```
zxq9 commented 2022-04-28 00:25:48 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

It is line 1, column 11 in BLS12_381.aes, right?

*Created by: hanssv* It is line 1, column 11 in `BLS12_381.aes`, right?
zxq9 commented 2022-04-28 01:31:19 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: dincho

Sure, but then the file/where (BLS12_381.aes, ) is missing ?

*Created by: dincho* Sure, but then the file/where (BLS12_381.aes, ) is missing ?
zxq9 commented 2022-04-28 01:35:17 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: dincho

For example the buildin namespace error makes much more sense:

Type error in 'contracts/Bug.aes' at line 5, col 11:
The namespace MCL_BLS12_381 (at line 5, column 11) has the same name as a namespace at (builtin location)

So I'd expect:

The namespace BLS12_381 (at line 5, column 11) has the same name as a namespace at line 1, column 11 in BLS12_381.aes

*Created by: dincho* For example the buildin namespace error makes much more sense: > Type error in 'contracts/Bug.aes' at line 5, col 11: > The namespace MCL_BLS12_381 (at line 5, column 11) has the same name as a namespace at (builtin location) So I'd expect: > The namespace BLS12_381 (at line 5, column 11) has the same name as a namespace at line 1, column 11 in BLS12_381.aes
zxq9 commented 2022-04-28 01:40:24 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: dincho

Not very helpful with user defined namespaces as well:

➜  cat contracts/Bug.aes                   
@compiler >= 6

include "Bug2.aes"

namespace Busy =
    type bus = int

main contract Bug =
    type number = int

➜ cat contracts/Bug2.aes                  
@compiler >= 6

namespace Busy =
    type bus = int

➜ aesophia_cli contracts/Bug.aes          
Type error in 'contracts/Bug.aes' at line 5, col 11:
The namespace Busy (at line 5, column 11) has the same name as a namespace at line 3, column 11
*Created by: dincho* Not very helpful with user defined namespaces as well: ``` ➜ cat contracts/Bug.aes @compiler >= 6 include "Bug2.aes" namespace Busy = type bus = int main contract Bug = type number = int ➜ cat contracts/Bug2.aes @compiler >= 6 namespace Busy = type bus = int ➜ aesophia_cli contracts/Bug.aes Type error in 'contracts/Bug.aes' at line 5, col 11: The namespace Busy (at line 5, column 11) has the same name as a namespace at line 3, column 11 ```
zxq9 commented 2022-04-28 06:21:45 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

@ghallak is this something that could be improved?

*Created by: hanssv* @ghallak is this something that could be improved?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#378
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?