From cec56d867f741e66f78b9fde37d9081643599a2a Mon Sep 17 00:00:00 2001 From: Frank Denis Date: Tue, 23 Apr 2019 14:57:07 +0200 Subject: [PATCH] Lucet: set min-reserved-size to the same value as max-heap-size If is less than , the code will still assume that only bytes are accessible and will trap even if the runtime could allocate more.. So, `max` should always be <= `min`. Naming options is hard. --- test/default/wasi-test-wrapper.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/default/wasi-test-wrapper.sh b/test/default/wasi-test-wrapper.sh index 3ef6f844..599f32c9 100755 --- a/test/default/wasi-test-wrapper.sh +++ b/test/default/wasi-test-wrapper.sh @@ -13,7 +13,7 @@ if [ -z "$WASI_RUNTIME" ] || [ "$WASI_RUNTIME" = "lucet" ]; then lucetc-wasi \ --min-reserved-size "${MAX_MEMORY_MB}MiB" \ -o "${1}.so" --opt-level best "$1" && - lucet-wasi --dir=.:. "${1}.so" && + lucet-wasi --dir=.:. --max-heap-size "${MAX_MEMORY_MB}MiB" "${1}.so" && rm -f "${1}.so" && exit 0 fi fi