From a586df583a9ecd1387c3f7850f61b20ab41f05a3 Mon Sep 17 00:00:00 2001 From: Frank Denis Date: Tue, 5 Nov 2013 21:00:04 -0800 Subject: [PATCH] Use blake2b_init() *or* blake2b_init_key(). Calling both is not needed. --- .../blake2/ref/generichash_blake2b.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/libsodium/crypto_generichash/blake2/ref/generichash_blake2b.c b/src/libsodium/crypto_generichash/blake2/ref/generichash_blake2b.c index 8329ba38..5ef9d406 100644 --- a/src/libsodium/crypto_generichash/blake2/ref/generichash_blake2b.c +++ b/src/libsodium/crypto_generichash/blake2/ref/generichash_blake2b.c @@ -33,11 +33,11 @@ crypto_generichash_blake2b_init(crypto_generichash_blake2b_state *state, } assert(outlen <= UINT8_MAX); assert(keylen <= UINT8_MAX); - if (blake2b_init(state, (uint8_t) outlen) != 0) { - return -1; - } - if (key != NULL && keylen > 0U && - blake2b_init_key(state, (uint8_t) outlen, key, keylen) != 0) { + if (key == NULL || keylen <= 0U) { + if (blake2b_init(state, (uint8_t) outlen) != 0) { + return -1; + } + } else if (blake2b_init_key(state, (uint8_t) outlen, key, keylen) != 0) { return -1; } return 0;