diff --git a/src/libsodium/crypto_core/ed25519/ref10/ed25519_ref10.c b/src/libsodium/crypto_core/ed25519/ref10/ed25519_ref10.c index dda67360..ec6d86f5 100644 --- a/src/libsodium/crypto_core/ed25519/ref10/ed25519_ref10.c +++ b/src/libsodium/crypto_core/ed25519/ref10/ed25519_ref10.c @@ -992,10 +992,13 @@ int ge25519_is_on_main_subgroup(const ge25519_p3 *p) { ge25519_p3 pl; + fe25519 t; ge25519_mul_l(&pl, p); - return fe25519_iszero(pl.X); + fe25519_sub(t, pl.Y, pl.Z); + + return fe25519_iszero(pl.X) & fe25519_iszero(t); } int diff --git a/test/default/core_ed25519.c b/test/default/core_ed25519.c index e3f39c38..396161b5 100644 --- a/test/default/core_ed25519.c +++ b/test/default/core_ed25519.c @@ -130,11 +130,12 @@ main(void) assert(crypto_core_ed25519_is_valid_point(p) == 0); p[0] = 9; - assert(crypto_core_ed25519_is_valid_point(p) == 1); + assert(crypto_core_ed25519_is_valid_point(p) == 0); assert(crypto_core_ed25519_is_valid_point(max_canonical_p) == 1); assert(crypto_core_ed25519_is_valid_point(non_canonical_invalid_p) == 0); assert(crypto_core_ed25519_is_valid_point(non_canonical_p) == 0); + assert(crypto_core_ed25519_is_valid_point(not_main_subgroup_p) == 0); memcpy(p2, p, crypto_core_ed25519_BYTES); add_P(p2);