QPQ-AG/gmserialization
11
0
Fork 0
Code Issues Pull Requests 7 Actions Packages Projects Releases 2 Wiki Activity

add subname id #20

Closed
zxq9 wants to merge 3 commits from add-subname-id into master
pull from: add-subname-id
merge into: :master
Conversation 2 Commits 3 Files Changed 3
+23 -2
zxq9 commented 2019-08-05 02:00:38 +09:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Created by: skkw

*Created by: skkw*
zxq9 commented 2019-08-07 17:00:32 +09:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Created by: ThomasArts

I understand that you take base58 because we did so for name... but base58 is more expensive in encoding. That means that we have an attack vector where it gets really slow for long names... is there a maximum length allowed that we check before encoding?

If you would have a name of 10000 bytes it would take a 500ms to encode. When having a name of 20000 bytes, it takes 2 seconds.

*Created by: ThomasArts* I understand that you take base58 because we did so for name... but base58 is more expensive in encoding. That means that we have an attack vector where it gets really slow for long names... is there a maximum length allowed that we check before encoding? If you would have a name of 10000 bytes it would take a 500ms to encode. When having a name of 20000 bytes, it takes 2 seconds.
zxq9 commented 2019-08-08 20:03:25 +09:00 (Migrated from gitlab.com)
Copy Link
Copy Source

Created by: skkw

I've changed it to BASE64.

*Created by: skkw* I've changed it to BASE64.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 pig lipstick
Muggle-facing enhancements
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Dagadunn Pickmick apex132 dimitar.p.ivanov flambard (Markus Flambard) gchewy hans_sv pharpend spivee (Jarvis Carroll) thescientress (Cecille de Jesus) uwiger (Ulf Wiger) zxq9 (Craig Everett)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/gmserialization#20