QPQ-AG/gmhive_client
9
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Let workers finish old candidates. #5

Merged
uwiger merged 1 commits from spivee/patience into master 2025-05-28 18:27:19 +09:00
Conversation 2 Commits 1 Files Changed 1 +8 -3
spivee commented 2025-05-28 17:53:26 +09:00
Member
Copy Link

In the short term this short circuits the headaches around freeing memory across remote processes, and in the medium to long term this allows lower-power users to introduce micro-forks instead of being locked out of the game altogether.

[EDIT] This does result in the first N nonces in the candidate range to be skipped. Handling idle workers waiting for a candidate, vs active workers unaware of the new candidate, may require some more thought/state, or may be another easy fix, but it probably doesn't matter for now.

In the short term this short circuits the headaches around freeing memory across remote processes, and in the medium to long term this allows lower-power users to introduce micro-forks instead of being locked out of the game altogether. [EDIT] This does result in the first N nonces in the candidate range to be skipped. Handling idle workers waiting for a candidate, vs active workers unaware of the new candidate, may require some more thought/state, or may be another easy fix, but it probably doesn't matter for now.
spivee added 1 commit 2025-05-28 17:53:27 +09:00 
In the short term this short circuits the headaches around freeing
memory across remote processes, and in the medium to long term
this allows lower-power users to introduce micro-forks instead of
being locked out of the game altogether.
spivee requested review from uwiger 2025-05-28 17:53:45 +09:00
spivee requested review from zxq9 2025-05-28 17:53:45 +09:00
zxq9 approved these changes 2025-05-28 17:58:07 +09:00
zxq9 left a comment
Owner
Copy Link

Excellent, simple fix.

Excellent, simple fix.
uwiger approved these changes 2025-05-28 18:26:58 +09:00
uwiger merged commit 2c160b83a1 into master 2025-05-28 18:27:19 +09:00
uwiger deleted branch spivee/patience 2025-05-28 18:27:19 +09:00
Sign in to join this conversation.
Reviewers
No Reviewers
zxq9
uwiger
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/gmhive_client#5
No description provided.
Delete Branch "spivee/patience"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?