From fe11ee31ab0c3f4c4ed5ff433b893d55df422ff8 Mon Sep 17 00:00:00 2001
From: Artur Puzio <contact@puzio.waw.pl>
Date: Wed, 14 Apr 2021 13:02:47 +0200
Subject: [PATCH] Restore old binary and string comparison

Binary and string comparison is under consensus

This partially reverts commit d16f9a9579d0b901d8deb17dec87f6aa36d09744.
---
 src/aeb_fate_data.erl | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/src/aeb_fate_data.erl b/src/aeb_fate_data.erl
index 0b3a7fa..3879f14 100644
--- a/src/aeb_fate_data.erl
+++ b/src/aeb_fate_data.erl
@@ -325,13 +325,22 @@ lt(?ORD_ORACLE, ?FATE_ORACLE(A), ?FATE_ORACLE(B)) ->
   A < B;
 lt(?ORD_ORACLE_Q, ?FATE_ORACLE_Q(A), ?FATE_ORACLE_Q(B)) ->
   A < B;
-% Compare by first different bit. If one is prefix of another than shorter is smaller. (like in Erlang)
 lt(?ORD_STRING, ?FATE_STRING(A), ?FATE_STRING(B)) ->
-  A < B;
+  compare_bytes(A, B);
 lt(?ORD_BYTES, ?FATE_BYTES(A), ?FATE_BYTES(B)) ->
-  A < B;
+  compare_bytes(A, B);
 lt(?ORD_CONTRACT_BYTEARRAY, ?FATE_CONTRACT_BYTEARRAY(A), ?FATE_CONTRACT_BYTEARRAY(B)) ->
-  A < B.
+  compare_bytes(A, B).
+
+% Shorter comes first
+% On same length compare by first different bit
+compare_bytes(A, B) ->
+  SizeA = byte_size(A),
+  SizeB = byte_size(B),
+  case SizeA - SizeB of
+    0 -> A < B;
+    N -> N < 0
+  end.
 
 tuple_elements_lt(N,_A,_B, N) ->
     false;