From 238907e2a7019ddecec715d80cce0bf0e67c0f36 Mon Sep 17 00:00:00 2001 From: Jesper Louis Andersen Date: Wed, 17 Dec 2014 16:15:29 +0100 Subject: [PATCH] Fix bug in box_open_afternm + Improve readability of C code. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If we write EXP != 0 and EXP is a very large term, it is hard to see what it gets checked against, so we rewrite it as 0 != EXP so we instanly see what we check against. While here, teset against 0 != crypto_box_afternm(…) --- c_src/enacl_nif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/c_src/enacl_nif.c b/c_src/enacl_nif.c index 92c0af4..7326b24 100644 --- a/c_src/enacl_nif.c +++ b/c_src/enacl_nif.c @@ -191,7 +191,7 @@ ERL_NIF_TERM enif_crypto_box_open(ErlNifEnv *env, int argc, ERL_NIF_TERM const a return nacl_error_tuple(env, "alloc_failed"); } - if (crypto_box_open(result.data, padded_ciphertext.data, padded_ciphertext.size, nonce.data, pk.data, sk.data) != 0) { + if (0 != crypto_box_open(result.data, padded_ciphertext.data, padded_ciphertext.size, nonce.data, pk.data, sk.data)) { enif_release_binary(&result); return nacl_error_tuple(env, "failed_verification"); } @@ -274,7 +274,7 @@ ERL_NIF_TERM enif_crypto_box_open_afternm(ErlNifEnv *env, int argc, ERL_NIF_TERM return nacl_error_tuple(env, "alloc_failed"); } - if (crypto_box_open_afternm(result.data, m.data, m.size, nonce.data, k.data)) { + if (0 != crypto_box_open_afternm(result.data, m.data, m.size, nonce.data, k.data)) { enif_release_binary(&result); return nacl_error_tuple(env, "failed_verification"); }